Re: FVWM: large PipeReads

From: Mikhael Goikhman <migo_at_homemail.com>
Date: Thu, 18 Apr 2002 17:55:53 +0000

On 18 Apr 2002 11:01:20 -0600, Gregg Dameron wrote:
>
> Dominik Vogt wrote:
>
> > On Wed, Apr 17, 2002 at 07:29:25PM -0600, Gregg Dameron wrote:
> > > Running 2.4.5 on Solaris.
> >
> > In fvwm, a single command line can not be longer than 1022
> > characters (1024 minus 1 for the string end minus 1 for the
> > trailing newline).
> >
> > > I suppose one workaround is to Exec a separate script and FvwmCommand
> > > the output, but I'm anxious to optimize performance.
> >
> > No, the limit is everywhere, not just in piperead. If that's too
> > small, the limit can be increased, but I wonder how you manage to
> > generate single commands that are bigger than 1k.
>
> I would vote in favor of an increase. It's easy for a PipeRead script to
> grow quickly, when you consider Bourne looping and branching constructs
> (for, if, case), all of which count toward the limit. There's a PipeRead
> in the distribution (system.fvwm2rc-sample-95) that exceeds 500 bytes
> before parameter expansion. The "for i in ... ; do" statement alone is
> over 230 bytes. Once I saw that sample, I jumped to the conclusion that
> arbitrarily long PipeReads were not only supported, but tacitly
> recommended.

Well, the limit was 256 I think, it was changed especially for
system.fvwm2rc-sample-95. :) I have nothing against to double it to 2Kb.
But the tactical recomendation is to use separate (not embedded) scripts.

> > > BTW, I noticed that the "about to exec" debug messages chop off the last
> > > character of the line read in. In read.c:
> > >
> > > if (debugging)
> > > fvwm_msg(DBG,"ReadSubFunc","Module switch %d, about to exec:
> > > '%.*s'",
> > > Module,strlen(tline)-1,tline);
> > >
> > > Perhaps the "-1" shouldn't be there?
> >
> > It's the trailing newline that gets cut off.
>
> Hmm. Here's a sample of what I get:
>
> [FVWM.1][ReadSubFunc]: <<DEBUG>> Module switch -1, about to exec:
> 'DestroyFunc ChangeAppsMa'
[...]
> It doesn't happen this way on yours and others' systems?

This was fixed 2 days after 2.4.5 was released, upgrade to 2.4.7.

Regards,
Mikhael.
--
Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_fvwm.org.
To report problems, send mail to fvwm-owner_at_fvwm.org.
Received on Thu Apr 18 2002 - 12:56:28 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:53 BST