Re: FVWM: Multi-screen patch redux

From: Grant McDorman <grant_at_isgtec.com>
Date: Tue, 25 Feb 1997 11:39:50 -0500 (EST)

-----BEGIN PGP SIGNED MESSAGE-----


On 20-Feb-97 23:41:45 Mark Boyns wrote:
> "Barry A. Warsaw" <bwarsaw_at_anthem.cnri.reston.va.us> writes:
>
> > On 26 Sep 1996, I posted a patch to fix a problem with handling focus
> > on multiple screen systems. The problem manifested itself when moving
> > the pointer from a window on e.g. screen 0 to the root window of
> > screen 1. In these situations, screen 0 would still get focus. See
> > my message of that date for details.
> >
> > The fix was simple, I thought. But then on 30 Sep 1996, Mark Boyns
> > followed up with a note that under SloppyFocus there were focus
> > problems with my patch. Chuck subsequently did not install my patch
> > in 2.0.45.
> >
> > I've just spent some time tracking all this down, and I now think that
> > Mark's problem has nothing to do with my patch (sorry Mark ;). I
> > think the SloppyFocus problem exists in 2.0.45 with or without my
> > patch. I'd like Mark (or any other multi-screener) to verify, but I
> > have been able to reproduce the problem from Mark's description with a
> > vanilla 2.0.45. My patch does nothing to fix or hurt this, AFAICT.
>
> Here's what I said on 30 Sept 1996:
>
> I just tried the patch and it only works a little better for me. It
> seems to only do the right thing when there are no windows that accept
> focus on the second screen.

[cut]

The problem here is in focus.c; the attached patch fixes it to have
the desired behaviour.

Grant McDorman <grant_at_isgtec.com>
ISG Technologies, Inc. http://www.isgtec.com
Mississauga, Ontario, Canada


-----BEGIN PGP SIGNATURE-----
Version: 2.6.2

iQBVAwUBMxMWd0Dmya2cFZ8ZAQEYQwIAqJtjjUj6qxg6nc1ECc/BK+iC64iXh4Rm
wcY9jQD3d09+U8wda0T7gjNEAzHd8X/pvF5JBdJOHOSA+dROV2ptJw==
=vr2X
-----END PGP SIGNATURE-----


*** ../../fvwm-2.0.43/fvwm/focus.c Tue Apr 30 14:00:28 1996
--- focus.c Tue Feb 25 11:36:06 1997
***************
*** 55,61 ****
        Fw->prev = &Scr.FvwmRoot;
      }
  
! if(Scr.NumberOfScreens > 1)
      {
        XQueryPointer(dpy, Scr.Root, &JunkRoot, &JunkChild,
                      &JunkX, &JunkY, &JunkX, &JunkY, &JunkMask);
--- 55,61 ----
        Fw->prev = &Scr.FvwmRoot;
      }
  
! if(Scr.NumberOfScreens > 1 && Fw != NULL)
      {
        XQueryPointer(dpy, Scr.Root, &JunkRoot, &JunkChild,
                      &JunkX, &JunkY, &JunkX, &JunkY, &JunkMask);
***************
*** 132,138 ****
        Scr.Focus = Fw;
        Scr.UnknownWinFocused = None;
      }
! else if ((Scr.Focus)&&(Scr.Focus->Desk == Scr.CurrentDesk))
      {
        /* Window doesn't want focus. Leave focus alone */
        /* XSetInputFocus (dpy,Scr.Hilite->w , RevertToParent, lastTimestamp);*/
--- 132,138 ----
        Scr.Focus = Fw;
        Scr.UnknownWinFocused = None;
      }
! else if ((Scr.Focus)&&(Scr.Focus->Desk == Scr.CurrentDesk) && Fw != NULL)
      {
        /* Window doesn't want focus. Leave focus alone */
        /* XSetInputFocus (dpy,Scr.Hilite->w , RevertToParent, lastTimestamp);*/

End of MIME message
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Tue Feb 25 1997 - 10:46:20 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:38:00 BST