Re: FVWM: Patch to eliminate blink

From: <Jonathan_Monahan_at_HP-Pinewood-om1.om.hp.com>
Date: Fri, 3 May 96 18:25:23 +0100

> ----------
> Dan Niles <dan_at_more.net> writes:
> >
> > Here is a patch that eliminates the blink of border color when a window
> > is closed.
> >
> > This is not the most elegant solution, but it shows that the problem is
> > the order in which the window is closed.
> >
> > ------------------------- fvwm-2.0.42-NoBlink.patch
-------------------------
> > -
> > --- builtins.c.orig Wed Apr 10 12:38:25 1996
> > +++ builtins.c Fri May 3 11:02:22 1996
> > _at_@ -598,6 +598,7 @@
> >
> > if (tmp_win->flags & DoesWmDeleteWindow)
> > {
> > + XUnmapWindow(dpy, tmp_win->frame);
> > send_clientmessage (tmp_win->w, _XA_WM_DELETE_WINDOW, CurrentTime);
> > return;
> > }
>
> Ahh, finally some progress.
>
> I'm not sure we are on the same track, I never noticed any frame
> blinking. What I see is the frame filling with the "unhilite color"
> during window takedown.
>
> I tried this:
>
> Around line 1900 in builtins.c, I removed this line:
>
> XUnmapWindow(dpy,w);
>
> Therefore only unmapping the frame. I think it automatically unmaps
> the window inside.

Yes, but then, when the app queries its display state, it will get Mapped (I
think), rather than Unmapped. I think we need to unmap the frame first, and
then unmap the application window. Of course, the second unmap doesn't have any
visual effect, it just keeps the application sweet.

> This seems to fix the frame filling problem during
> iconify, but I still see the frame fill when I exit an application.
> (For example typing "q" in an xv window.)
>

Yup, that's the one I was aiming for.

> Any testing has to be done with the cpu very busy.
>
> It does seem to speed up iconifying also.
>
> > --
>
> --
> Dan Espen Phone: (908) 699-5570
> dane_at_bae.bellcore.com
> 444 Hoes Lane Room RRC 1C-214
> Piscataway, NJ 08854
> --
> Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
> To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
> message to majordomo_at_hpc.uh.edu.
> To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
>

Jonathan.
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Fri May 03 1996 - 12:13:43 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:58 BST