Re: FVWM: Found another bug in FVWM 2.2

From: Dan D Niles <dan_at_more.net>
Date: Tue, 9 Mar 1999 12:37:02 -0600

Doh! I responded to the wrong message. This is the message I meant to
respond to.

I tracked down the bug. When a function has double click actions
single clicks get the wrong type. Below (end of this message) is a
patch that fixes the bug.

Dan

> I have the following functions and bindings in my fvwm2rc:
>
> AddToFunc Title-Bar-Fun
> + "M" Move
> + "D" WindowShade
> + "C" Raise
>
> AddToFunc Raise-unless-Move
> + "M" Move
> + "C" Raise
>
> Mouse 1 T 5 Title-Bar-Fun
> Mouse 1 WSFI 5 Raise-unless-Move
>
>
> The C option works in Raise-unless-Move but not in Title-Bar-Fun.
> If I remove the D option from Title-Bar-Fun, it works fine. It worked
> fine in version 2.0.46.
>
> I would appreciate it if someone else could test this to verify that
> it is a bug.
>
> Thanks,
>
>
> Dan
>
> --
> Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
> To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
> message to majordomo_at_fvwm.org.
> To report problems, send mail to fvwm-owner_at_fvwm.org.
>

--- fvwm/complex.c.orig Tue Mar 9 12:04:57 1999
+++ fvwm/complex.c Tue Mar 9 12:18:57 1999
_at_@ -179,6 +179,13 @@
       type = DOUBLE_CLICK;
       ev = &d;
     }
+ /* If a function has DOUBLE_CLICK actions, a single click results in
+ * type = ONE_AND_A_HALF_CLICKS, which causes CLICK actions to stop
+ * working. This hack fixes it, but the way double clicks are
+ * handled should probably be fixed in a better way.
+ * Bug fix by -DDN- (Dan D Niles dniles_at_iname.com or dan_at_more.net) */
+ if( type == ONE_AND_A_HALF_CLICKS ) type = CLICK; /* -DDN- */
+
   /* some functions operate on button release instead of
    * presses. These gets really weird for complex functions ... */
   if(ev->type == ButtonPress)

--
Visit the official FVWM web page at <URL: http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_fvwm.org.
To report problems, send mail to fvwm-owner_at_fvwm.org.
Received on Tue Mar 09 1999 - 12:37:51 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:38:02 BST