FVWM: Re:Proposed patch (Was: FlipFocus & MouseFocus)

From: Nadim Saeed <nadim_at_metaflow.com>
Date: Thu, 20 Mar 1997 13:42:02 -0800 (PST)

Markus Gutschke wrote:
>
> I whipped up a really simple patch that might improve the behavior of
> "FlipFocus" when used in mouse-focus mode. I have done *very* little
> testing and it is quite possible that this patch breaks some other
> functionality. First impressions suggest, that the new behavior is
> more correct than the old one. As I do not fully understand FVWM's
> internal handling of window lists, I would very much appreciate if
> somebody else took a close look at this fix and checks that it takes
> the right approach.
>
> Markus
>
> --- events.c.orig Fri Mar 7 14:58:06 1997
> +++ events.c Fri Mar 7 14:47:03 1997
> _at_@ -1117,12 +1117,16 @@
>
> if(!(Tmp_win->flags & ClickToFocus))
> {
> +#if 0
> if(Scr.Focus != Tmp_win)
> {
> SetFocus(Tmp_win->w,Tmp_win,0);
> }
> else
> SetFocus(Tmp_win->w,Tmp_win,0);
> +#else
> + SetFocus(Tmp_win->w,Tmp_win,1);
> +#endif
> }
> if (Scr.ColormapFocus == COLORMAP_FOLLOWS_MOUSE)
> {
>

Markus, I've been using your patch for the past couple of weeks and it seems
solid. I fail to see the functionality of the code above (the code that was
essentially excluded), yet I'm not too familiar with the internals of Fvwm
either.

Alas, will this patch make it in the next release (if not, could we get
something IN that will insure FlipFocus' functionality when used in
conjunction with MouseFocus) ?

NOTE: the above patch applies to fvwm-2.0.45

 - Nadim

--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Thu Mar 20 1997 - 15:46:11 GMT

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:38:00 BST