FVWM: Re: FVWM-2 WindowList

From: Scary Guy <scaryguy_at_sanitarium.mit.edu>
Date: Tue, 11 Jun 1996 23:20:52 -0400 (EDT)

> Hi,
> On Fri, 7 Jun 1996 chuck_hines_at_VNET.IBM.COM wrote:
>>>>>>> "Scary" == Scary Guy <scaryguy_at_sanitarium.mit.edu> writes:
>>> Well, the funny thing I noticed is that when you actually
>>> click on the windows, they get reordered in the WindowList,
>>> whereas if you just select the window in the WindowList itself, they
>>> don't. I myself am not a programmer extraordinaire, but it
>>> seems as if this could be changed relatively easily. (That's
>>> why I posted this question in the first place.)

>> I just tried that, and observed that behavior as well. It is a bug
>> by my way of thinking, although I'll have to look a little harder to
>> figure out what's really wrong. It probably won't be fixed in the
>> next beta or the first offical release, but I'll see what I can do
>> (i.e. it'll make it to the TO-DO list as a bug).

> That behaviour seems to be caused by the SetFocus() call with the 3rd
> parameter as zero in FocusOn(), builtins.c.

> The SetFocus function moves the focused window to the top of the list
> only if the 3rd parameter is set to True, apparently for click-to-
> focus operations only (is not very clear to me why only in that case,
> do we really need that 3rd parameter?).
 
> The following patch corrects the problem, for both the WindowList menu
> and SloppyFocus prev/next.
 
> --- builtins.c.orig Sat Jun 8 11:15:06 1996
> +++ builtins.c Sat Jun 8 11:15:28 1996
> _at_@ -211,7 +211,7 @@
> XWarpPointer(dpy, None, Scr.Root, 0, 0, 0, 0, 2,2);
> }
> UngrabEm();
> - SetFocus(t->w,t,0);
> + SetFocus(t->w,t,1);
> }

I just tried making the necessary changes to builtins.c in the fvwm-95
source code (2.0.42) and this did not fix the problem.

Thanks
--
Visit the official FVWM web page at <URL:http://www.hpc.uh.edu/fvwm/>.
To unsubscribe from the list, send "unsubscribe fvwm" in the body of a
message to majordomo_at_hpc.uh.edu.
To report problems, send mail to fvwm-owner_at_hpc.uh.edu.
Received on Tue Jun 11 1996 - 22:24:11 BST

This archive was generated by hypermail 2.3.0 : Mon Aug 29 2016 - 19:37:59 BST